[PATCH] D110239: [AArch64] Enable type promotion for AArch64

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 09:40:19 PDT 2021


dmgreen added a comment.

In D110239#3015115 <https://reviews.llvm.org/D110239#3015115>, @samparker wrote:

> I didn't think about the extra latency of a uxt cmp, and I wouldn't have thought it useful with GISel either - so this is a pleasant surprise. Do you reckon it's worth sorting out the sign extend dag patterns before enabling? Or do you think that the change is really gonna be in the noise so much that no-one will notice?

I think they are fairly specific cases, so either way would hopefully be OK. They are deliberate tests for the code in TargetLowering::optimizeSetCCOfSignedTruncationCheck, which is not firing in the new form (and I don't see it coming up in other benchmarks). I'll look into trying to fix it when I get some time, but you know, have other patches that are likely more important to fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110239/new/

https://reviews.llvm.org/D110239



More information about the llvm-commits mailing list