[PATCH] D110259: [SVE][Analysis] Tune the cost model according to the tune-cpu attribute

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:371-373
+  if (TuneCPU == "generic") return 4;
+  else if (TuneCPU == "neoverse-v1") return 2;
+  else if (TuneCPU == "neoverse-n2") return 1;
----------------
dmgreen wrote:
> These per-cpu values should probably be subtarget features or defined in AArch64Subtarget::initializeProperties like the other alignments and whatnot.
Hi @dmgreen, I think that's perfectly sensible when you only have a target-cpu feature. I originally tried doing it that way, but realised if target-cpu=generic and tune-cpu=neoverse-n1 then the subtarget won't have max vscale set, since we chose a generic subtarget.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110259/new/

https://reviews.llvm.org/D110259