[PATCH] D109794: [Sanitizer] Allow setting the report path to create directory

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 08:07:24 PDT 2021


tejohnson added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_win.cpp:568
 
+bool CreateDir(const char *pathname) { return _mkdir(pathname) == 0; }
+
----------------
morehouse wrote:
> This line caused a build breakage on the sanitizer bot:  https://lab.llvm.org/buildbot/#/builders/127/builds/17222
> 
> ```
> C:\...\sanitizer_win.cpp(568): error C3861: '_mkdir': identifier not found
> ```
> 
> Could you please take a look?
Sorry, missed that one. Hopefully 1864976c967de36146eb5a5b86e6312d466e1031 that I just committed should take care of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109794/new/

https://reviews.llvm.org/D109794



More information about the llvm-commits mailing list