[PATCH] D110100: [NFCI][CodeGen, AArch64] Fix inconsistent TargetCostKind types.

Daniil Fukalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 04:11:48 PDT 2021


dfukalov added a comment.

In D110100#3014761 <https://reviews.llvm.org/D110100#3014761>, @RKSimon wrote:

> In D110100#3014729 <https://reviews.llvm.org/D110100#3014729>, @samparker wrote:
>
>>> Do you think we should stop using default cost kinds entirely?
>>
>> I think this would be for the best, and I thought I already changed most of the calls to be explicit.
>
> @dfukalov Is this something you'd be willing to do in this patch? At least for getInstructionCost + getInterleavedMemoryOpCost (TTI + Impl)?

I guess suggested changes should be in different patch, I just checked who uses pure latency cost kind our days and found this inconsistency.
Perhaps the fix may be "less invasive" with using `TCK_Latency` in both places, but they seems equal at the moment and I'm not sure the author meant exactly pure latency here...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110100/new/

https://reviews.llvm.org/D110100



More information about the llvm-commits mailing list