[PATCH] D109816: [hwasan] also omit safe mem[cpy|mov|set].

[Florian Mayer via Phabricator via llvm-commits]

fmayer marked 2 inline comments as done.
fmayer added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:928
+        if ((isa<StoreInst>(I) || isa<LoadInst>(I) || isa<MemIntrinsic>(I) ||
+             (Call && Call->hasByValArgument())) &&
+            stackAccessIsSafe(I)) {
----------------
eugenis wrote:
> This is kind of ugly, but ok for a debug print. We could also
> * skip the instructions that are not in AccessIsUnsafe
> * print unsafe instructions instead of safe ones.
> 
> Up to your what seems easiest.
Makes sense. Let's submit this and maybe do this in a follow up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109816/new/

https://reviews.llvm.org/D109816