[compiler-rt] ae6d57c - tsan: remove stale comment

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 22 01:19:02 PDT 2021


Author: Dmitry Vyukov
Date: 2021-09-22T10:18:58+02:00
New Revision: ae6d57ca5a945063a25181e3875c1fcf3787a040

URL: https://github.com/llvm/llvm-project/commit/ae6d57ca5a945063a25181e3875c1fcf3787a040
DIFF: https://github.com/llvm/llvm-project/commit/ae6d57ca5a945063a25181e3875c1fcf3787a040.diff

LOG: tsan: remove stale comment

We do query it every 100ms now.
(GetRSS was fixed to not be dead slow IIRC)

Depends on D110152.

Reviewed By: melver, vitalybuka

Differential Revision: https://reviews.llvm.org/D110153

Added: 
    

Modified: 
    compiler-rt/lib/tsan/rtl/tsan_rtl.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp b/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
index 294f3d31a057..0bc7ab3291c6 100644
--- a/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_rtl.cpp
@@ -205,7 +205,6 @@ static void *BackgroundThread(void *arg) {
         last_flush = NanoTime();
       }
     }
-    // GetRSS can be expensive on huge programs, so don't do it every 100ms.
     if (flags()->memory_limit_mb > 0) {
       uptr rss = GetRSS();
       uptr limit = uptr(flags()->memory_limit_mb) << 20;


        


More information about the llvm-commits mailing list