[PATCH] D110212: [llvm-profgen] Use hot threshold for context merging and trimming

Tue Sep 21 20:26:24 PDT 2021

hoy accepted this revision.
hoy added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:431
-  if (!ProfileSummaryCutoffCold.getNumOccurrences())
-    ProfileSummaryCutoffCold = 999000;
-
----------------
wenlei wrote:
> hoy wrote:
> > Does it still make sense to keep this? Would profile summary builder use this value?
> Profile summary builder still use it, but the removed tuning was only needed for merging/trimming. Now that merging/trimming changed to use hot threshold, the tuning is no longer needed either. The tuning may not general enough for a good cold threshold. 
Sounds good.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110212/new/

https://reviews.llvm.org/D110212