[PATCH] D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:136
   };
+  Config.DebugPassManager = DebugPassManager;
 }
----------------
w2yehia wrote:
> tejohnson wrote:
> > Needed in ThinLTOCodeGenerator.cpp too? Looks like it is passed down from llvm-lto to there but I assume you wanted to set this via the linker? Not a legacy LTO user though, @steven_wu may have more thoughts.
> Yep, I intend to pass this option via the linker. Sorry for keep forgetting about thinLTO; we don't use it yet.
> 
> If we are to add processing of the DebugPassManager cl::opt to ThinLTOCodeGenerator then we'll have to remove it from llvm-lto, and remove the DebugPassManager parameter from a bunch of static functions in ThinLTOCodeGenerator.cpp.
> 
> @fhahn FYI, since you added that code.
Thanks that should be fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110075/new/

https://reviews.llvm.org/D110075