[PATCH] D110186: Fix tests defaulting to incorrect triples on AIX

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 13:53:18 PDT 2021


jrtc27 added a comment.

In D110186#3013531 <https://reviews.llvm.org/D110186#3013531>, @MaskRay wrote:

>> The tests only specify -march, so when the tests are run on AIX the target OS defaults to AIX, which causes the tests to misbehave.
>
> Can you confirm? I don't think so.
>
> See `llvm/lib/Support/Triple.cpp:getDefaultFormat`. ELF is the default binary format for everything except wasm.
> This does give ELF a privilege but that is just how things work:)

-march is defined to be "the native triple with the CPU replaced with the argument" and has caused problems in the past. It's not the same as -mtriple where there are defaults that don't depend on the native triple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110186/new/

https://reviews.llvm.org/D110186



More information about the llvm-commits mailing list