[PATCH] D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 11:59:00 PDT 2021


steven_wu added a comment.

+ @davide who might have more context of LC_CODE_SIGNITURE section

I totally agree that the API/Implementation you copied from lld is very not libObject. There should not be a write function inside libObject (you can reimplement it inside llvm-copy or other utilities).
I am also not quite sure what is your usecase for `llvm-objcopy`?  That is not a tool available for Darwin and there is no guarantee that a `objcopy` of the binary can still run (could be a bincompat problem).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109972/new/

https://reviews.llvm.org/D109972



More information about the llvm-commits mailing list