[PATCH] D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr

Matt Jacobson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 11:13:31 PDT 2021


mhjacobson added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRInstrInfo.cpp:578
+         // out in 'fixStackStores(..)'.
+         MI.getOpcode() == AVR::STDWSPQRr || MI.getOpcode() == AVR::STDSPQRr;
+}
----------------
If `fixStackStores()` is now being called for each `STDWSPQRr` and `STDSPQRr`, does the loop inside `fixStackStores()` still make sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95664/new/

https://reviews.llvm.org/D95664



More information about the llvm-commits mailing list