[PATCH] D110126: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on FreeBSD

[Dimitry Andric via Phabricator via llvm-commits]

dim added a comment.

I tried building head-of-main with `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON`, and one thing I noticed is that the directories have the minor version swizzled in:

  % ls -l /share/dim/llvm/llvmorg-14-init-4370-gd87d1aa07612-freebsd14-amd64-ninja-clang-rel-1/lib/clang/14.0.0/lib
  total 8
  drwxr-xr-x  2 dim  dim  1024 2021-09-21 11:07:47 i386-unknown-freebsd14.0/
  drwxr-xr-x  2 dim  dim  1536 2021-09-21 11:07:47 x86_64-unknown-freebsd14.0/

I'd rather not have that, since we've had other trouble with it, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258377 (where Python builds get confused by the dot in the `-print-multiarch` output).

@emaste @arichardson do you agree with that? I think the best solution is to use only the major version number, e.g. `i386-unknown-freebsd14` and `x86_64-unknown-freebsd14`? But this may require some changes in the code that handles triples.

(Note that Linux appears to get rid of the OS version entirely, e.g. it has ` lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110126/new/

https://reviews.llvm.org/D110126