[PATCH] D110171: [VectorCombine] Switch to using a worklist.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 373981.
fhahn added a comment.

Remove DbgPrefix, use pushValue, avoid using deferred worklist part.

In D110171#3013003 <https://reviews.llvm.org/D110171#3013003>, @nikic wrote:

>> This may either be an oversight, or an intentional improvement that guarantees that in this pass we don't repeat instcombine's mistake
>> of relying on 3., but consistently add everything we want reprocessed into worklist.

Thanks for elaborating! I think for now it is not worth re-processing the whole function, because the combines are very limited in scope. It would probably be best to make sure the correct instructions are added to the worklist instead, e.g. note the updates around line 522 which ensure we can clean up now-dead extracts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110171/new/

https://reviews.llvm.org/D110171

Files:
  llvm/lib/Transforms/Vectorize/VectorCombine.cpp
  llvm/test/Transforms/PhaseOrdering/AArch64/matrix-extract-insert.ll
  llvm/test/Transforms/VectorCombine/AArch64/load-extract-insert-store-scalarization.ll
  llvm/test/Transforms/VectorCombine/X86/extract-binop-inseltpoison.ll
  llvm/test/Transforms/VectorCombine/X86/extract-binop.ll
  llvm/test/Transforms/VectorCombine/load-insert-store.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110171.373981.patch
Type: text/x-patch
Size: 13802 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210921/af58a32f/attachment.bin>