[PATCH] D110181: [InstCombine] Move InstCombineWorklist to Utils to allow reuse (NFC).

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/InstructionWorklist.h:33
 
+  const char *DbgPrefix = "IC";
+
----------------
spatel wrote:
> Is it necessary to have that prefix? That part is just noise to me when I'm scrolling through instcombine debug spew. No tests should be depending on matching that...
I removed the prefix part for now.


================
Comment at: llvm/include/llvm/Transforms/Utils/InstructionWorklist.h:21
 
 #define DEBUG_TYPE "instcombine"
 
----------------
spatel wrote:
> fhahn wrote:
> > lebedev.ri wrote:
> > > Update
> > I removed it here and moved the user includes after the `DEBUG_TYPE` definitions at the include site. Not sure if there's a better way to customize the DEBUG_TYPE string here.
> Do we really need for the caller's DEBUG_TYPE to be set, or can we just define that here as "instruction-utils" or something like that? That's what it looks like in BasicBlockUtils.cpp (so might have to split this into a header and source file pair?).
I think we could just use a different `DEBUG_TYPE` here, but then we would miss update messages from the worklist with `-debug-only=instcombine`. Not sure if that's preferable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110181/new/

https://reviews.llvm.org/D110181