[PATCH] D109816: [hwasan] also omit safe mem[cpy|mov|set].

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 10:22:21 PDT 2021


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:928
+        if ((isa<StoreInst>(I) || isa<LoadInst>(I) || isa<MemIntrinsic>(I) ||
+             (Call && Call->hasByValArgument())) &&
+            stackAccessIsSafe(I)) {
----------------
This is kind of ugly, but ok for a debug print. We could also
* skip the instructions that are not in AccessIsUnsafe
* print unsafe instructions instead of safe ones.

Up to your what seems easiest.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109816/new/

https://reviews.llvm.org/D109816



More information about the llvm-commits mailing list