[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

[John Ericson via Phabricator via llvm-commits]

Ericson2314 added inline comments.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509
     set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR
-      ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded)
+      ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded)
     set(DARWIN_macho_embedded_LIBRARY_INSTALL_DIR
----------------
arphaman wrote:
> It looks like this change broke the `macho_embedded` layout for Darwin's compiler-rt build, so now the clang driver isn unable to find these libraries.
> 
> I will commit a change that uses `COMPILER_RT_OUTPUT_DIR` again for the `macho_embedded` libraries.
Can you help me understand this better? `COMPILER_RT_OUTPUT_LIBRARY_DIR` should be defined to be the same thing unless target-specific directories are used, Is the problem in the latter case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105765/new/

https://reviews.llvm.org/D105765