[PATCH] D110171: [VectorCombine] Switch to using a worklist.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D110171#3012911 <https://reviews.llvm.org/D110171#3012911>, @lebedev.ri wrote:

> Hmm, but this still doesn't do instcombine-style whole-function reprocessing ("iteration"), but only reprocesses the ones explicitly added to worklist.
> This is intentional?

At the moment, the first combining round is done by iterating over the function without the worklist. Only if something gets simplified, the modified instructions are added. Is this what you are referring to? I did not add all instructions to the worklist up front intentionally.

The number of combines is quite limited at the moment and I expect there are a lot of functions where no combine triggers at all. In those cases, adding everything to the worklist first seems a bit of unnecessary overhead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110171/new/

https://reviews.llvm.org/D110171