[llvm] c0fdfc9 - [InstCombine] powi(x, y) * powi(x, z) -> powi(x, y + z)
Dávid Bolvanský via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 21 09:20:53 PDT 2021
Author: Dávid Bolvanský
Date: 2021-09-21T18:20:46+02:00
New Revision: c0fdfc9af2338fa84f1b65dda8f1649c0ec1ebf1
URL: https://github.com/llvm/llvm-project/commit/c0fdfc9af2338fa84f1b65dda8f1649c0ec1ebf1
DIFF: https://github.com/llvm/llvm-project/commit/c0fdfc9af2338fa84f1b65dda8f1649c0ec1ebf1.diff
LOG: [InstCombine] powi(x, y) * powi(x, z) -> powi(x, y + z)
We already have pow(x, y) * pow(x, z) -> pow(x, y + z) transformation, but we are missing same transformation for powi (power is integer).
Requires reassoc.
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D109954
Added:
Modified:
llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
llvm/test/Transforms/InstCombine/powi.ll
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp b/llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
index 6f2a8ebf839a..ccde3ad53a7d 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
@@ -564,6 +564,16 @@ Instruction *InstCombinerImpl::visitFMul(BinaryOperator &I) {
return replaceInstUsesWith(I, NewPow);
}
+ // powi(x, y) * powi(x, z) -> powi(x, y + z)
+ if (match(Op0, m_Intrinsic<Intrinsic::powi>(m_Value(X), m_Value(Y))) &&
+ match(Op1, m_Intrinsic<Intrinsic::powi>(m_Specific(X), m_Value(Z))) &&
+ Y->getType() == Z->getType()) {
+ auto *YZ = Builder.CreateAdd(Y, Z);
+ auto *NewPow = Builder.CreateIntrinsic(
+ Intrinsic::powi, {X->getType(), YZ->getType()}, {X, YZ}, &I);
+ return replaceInstUsesWith(I, NewPow);
+ }
+
// exp(X) * exp(Y) -> exp(X + Y)
if (match(Op0, m_Intrinsic<Intrinsic::exp>(m_Value(X))) &&
match(Op1, m_Intrinsic<Intrinsic::exp>(m_Value(Y)))) {
diff --git a/llvm/test/Transforms/InstCombine/powi.ll b/llvm/test/Transforms/InstCombine/powi.ll
index 36f75a0020f7..54bf33f4e5e4 100644
--- a/llvm/test/Transforms/InstCombine/powi.ll
+++ b/llvm/test/Transforms/InstCombine/powi.ll
@@ -143,10 +143,9 @@ entry:
define double @powi_fmul_powi(double %x, i32 %y, i32 %z) {
; CHECK-LABEL: @powi_fmul_powi(
; CHECK-NEXT: entry:
-; CHECK-NEXT: [[P1:%.*]] = tail call double @llvm.powi.f64.i32(double [[X:%.*]], i32 [[Y:%.*]])
-; CHECK-NEXT: [[P2:%.*]] = tail call double @llvm.powi.f64.i32(double [[X]], i32 [[Z:%.*]])
-; CHECK-NEXT: [[MUL:%.*]] = fmul reassoc double [[P2]], [[P1]]
-; CHECK-NEXT: ret double [[MUL]]
+; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[Z:%.*]], [[Y:%.*]]
+; CHECK-NEXT: [[TMP1:%.*]] = call reassoc double @llvm.powi.f64.i32(double [[X:%.*]], i32 [[TMP0]])
+; CHECK-NEXT: ret double [[TMP1]]
;
entry:
%p1 = tail call double @llvm.powi.f64.i32(double %x, i32 %y)
@@ -158,10 +157,9 @@ entry:
define double @powi_fmul_powi_fast_on_fmul(double %x, i32 %y, i32 %z) {
; CHECK-LABEL: @powi_fmul_powi_fast_on_fmul(
; CHECK-NEXT: entry:
-; CHECK-NEXT: [[P1:%.*]] = tail call double @llvm.powi.f64.i32(double [[X:%.*]], i32 [[Y:%.*]])
-; CHECK-NEXT: [[P2:%.*]] = tail call double @llvm.powi.f64.i32(double [[X]], i32 [[Z:%.*]])
-; CHECK-NEXT: [[MUL:%.*]] = fmul fast double [[P2]], [[P1]]
-; CHECK-NEXT: ret double [[MUL]]
+; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[Z:%.*]], [[Y:%.*]]
+; CHECK-NEXT: [[TMP1:%.*]] = call fast double @llvm.powi.f64.i32(double [[X:%.*]], i32 [[TMP0]])
+; CHECK-NEXT: ret double [[TMP1]]
;
entry:
%p1 = tail call double @llvm.powi.f64.i32(double %x, i32 %y)
@@ -188,10 +186,9 @@ entry:
define double @powi_fmul_powi_same_power(double %x, i32 %y, i32 %z) {
; CHECK-LABEL: @powi_fmul_powi_same_power(
; CHECK-NEXT: entry:
-; CHECK-NEXT: [[P1:%.*]] = tail call double @llvm.powi.f64.i32(double [[X:%.*]], i32 [[Y:%.*]])
-; CHECK-NEXT: [[P2:%.*]] = tail call double @llvm.powi.f64.i32(double [[X]], i32 [[Y]])
-; CHECK-NEXT: [[MUL:%.*]] = fmul reassoc double [[P2]], [[P1]]
-; CHECK-NEXT: ret double [[MUL]]
+; CHECK-NEXT: [[TMP0:%.*]] = shl i32 [[Y:%.*]], 1
+; CHECK-NEXT: [[TMP1:%.*]] = call reassoc double @llvm.powi.f64.i32(double [[X:%.*]], i32 [[TMP0]])
+; CHECK-NEXT: ret double [[TMP1]]
;
entry:
%p1 = tail call double @llvm.powi.f64.i32(double %x, i32 %y)
@@ -205,15 +202,15 @@ define double @powi_fmul_powi_use_first(double %x, i32 %y, i32 %z) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[P1:%.*]] = tail call double @llvm.powi.f64.i32(double [[X:%.*]], i32 [[Y:%.*]])
; CHECK-NEXT: tail call void @use(double [[P1]])
-; CHECK-NEXT: [[P2:%.*]] = tail call double @llvm.powi.f64.i32(double [[X]], i32 [[Z:%.*]])
-; CHECK-NEXT: [[MUL:%.*]] = fmul reassoc double [[P2]], [[P1]]
-; CHECK-NEXT: ret double [[MUL]]
+; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[Y]], [[Z:%.*]]
+; CHECK-NEXT: [[TMP1:%.*]] = call reassoc double @llvm.powi.f64.i32(double [[X]], i32 [[TMP0]])
+; CHECK-NEXT: ret double [[TMP1]]
;
entry:
%p1 = tail call double @llvm.powi.f64.i32(double %x, i32 %y)
tail call void @use(double %p1)
%p2 = tail call double @llvm.powi.f64.i32(double %x, i32 %z)
- %mul = fmul reassoc double %p2, %p1
+ %mul = fmul reassoc double %p1, %p2
ret double %mul
}
@@ -222,9 +219,9 @@ define double @powi_fmul_powi_use_second(double %x, i32 %y, i32 %z) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[P1:%.*]] = tail call double @llvm.powi.f64.i32(double [[X:%.*]], i32 [[Z:%.*]])
; CHECK-NEXT: tail call void @use(double [[P1]])
-; CHECK-NEXT: [[P2:%.*]] = tail call double @llvm.powi.f64.i32(double [[X]], i32 [[Y:%.*]])
-; CHECK-NEXT: [[MUL:%.*]] = fmul reassoc double [[P2]], [[P1]]
-; CHECK-NEXT: ret double [[MUL]]
+; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[Y:%.*]], [[Z]]
+; CHECK-NEXT: [[TMP1:%.*]] = call reassoc double @llvm.powi.f64.i32(double [[X]], i32 [[TMP0]])
+; CHECK-NEXT: ret double [[TMP1]]
;
entry:
%p1 = tail call double @llvm.powi.f64.i32(double %x, i32 %z)
More information about the llvm-commits
mailing list