[PATCH] D110026: [Verifier] Verify scoped noalias metadata

Tue Sep 21 08:55:45 PDT 2021

nikic added a comment.

In D110026#3012747 <https://reviews.llvm.org/D110026#3012747>, @hgreving wrote:

> Seems like that this patch now contradicts the methods MDBuilder.h:createAnonymousAliasScopeDomain and createAnonymousAliasScope. If you actually give it a string, it won't verify. I wonder if you should amend this changing the methods as well?

These methods are intended to be supported and are used in-tree and do verify there. Could you provide an example that would fail? Please keep in mind that scoped alias metadata always deals in scope lists, while createAnonymousAliasScope() only creates an isolated scope. You cannot pass the result of createAnonymousAliasScope() directly to `!noalias`, `!alias.scope`, etc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110026/new/

https://reviews.llvm.org/D110026