[PATCH] D110171: [VectorCombine] Switch to using a worklist.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 08:52:54 PDT 2021


fhahn updated this revision to Diff 373953.
fhahn added a comment.

In D110171#3012460 <https://reviews.llvm.org/D110171#3012460>, @lebedev.ri wrote:

> Nice!
> I'm not sure it is a good idea to just reuse part of another pass like that.
> Perhaps `InstCombineWorklist` should be extracted+promoted to being more reusable?

Yeah, it should probably be moved. I put up D110181 <https://reviews.llvm.org/D110181> to move it to Utils and rename it to InstructionWorklist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110171/new/

https://reviews.llvm.org/D110171

Files:
  llvm/include/llvm/Transforms/Utils/InstructionWorklist.h
  llvm/lib/Transforms/Vectorize/VectorCombine.cpp
  llvm/test/Transforms/PhaseOrdering/AArch64/matrix-extract-insert.ll
  llvm/test/Transforms/VectorCombine/AArch64/load-extract-insert-store-scalarization.ll
  llvm/test/Transforms/VectorCombine/X86/extract-binop-inseltpoison.ll
  llvm/test/Transforms/VectorCombine/X86/extract-binop.ll
  llvm/test/Transforms/VectorCombine/load-insert-store.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110171.373953.patch
Type: text/x-patch
Size: 15102 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210921/57e4ec07/attachment-0001.bin>


More information about the llvm-commits mailing list