[PATCH] D109961: [AMDGPU] Avoid processing functions in amdgpu-propagate-attributes pass for shaders

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 08:08:46 PDT 2021


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

In D109961#3009438 <https://reviews.llvm.org/D109961#3009438>, @piotr wrote:

> I was thinking about this, but not sure what the test would demonstrate, as the patch just limits the number of cases for which this pass works. With this patch, there are no test changes in the existing set of tests, as expected.
>
> This patch causes an early exit for calling conventions where isShader() is true. We run early inlining in these cases.

It would show not touching the attributes on the function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109961/new/

https://reviews.llvm.org/D109961



More information about the llvm-commits mailing list