[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

[Kamau Bridgeman via Phabricator via llvm-commits]

kamaub added a reviewer: kamaub.
kamaub added a comment.

This patch seems almost ready to land to me, I'm just a bit concerned about the testing coverage, 
is the little endian testing case suppose to target `pwr7` as the big endian test does? The default 
FileCheck line seems redundant to me, did I misunderstand?



================
Comment at: llvm/test/CodeGen/PowerPC/test-vector-insert.ll:8
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \
+; RUN:  -mcpu=pwr7 < %s | FileCheck %s
+
----------------
It seems like this run line is redundant, it produces the same assembly as the big endian specific line above. Maybe the `-mcpu=pwr7` can be moved to the first Little-endian specific run line? That line currently only test the target cpu of the test machine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109902/new/

https://reviews.llvm.org/D109902