[PATCH] D110143: [Utils] Replace llc with cat for tests

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 07:39:01 PDT 2021


sebastian-ne updated this revision to Diff 373928.
sebastian-ne marked an inline comment as done.
sebastian-ne added a comment.

Use applySubstitutions in one more place.

> Not sure if that's much better than depending on %T though.

Ideally the update scripts would share the code with the lit script and we coud just use %t.
I’ll leave it at %T for now because that doesn’t depend on implementation details.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110143/new/

https://reviews.llvm.org/D110143

Files:
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_no_merge_comments-O0.s
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_no_merge_comments-O3.s
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_no_merge_comments.ll
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/amdgpu_no_merge_comments.ll.expected
  llvm/test/tools/UpdateTestChecks/update_llc_test_checks/amdgpu-no-merge-comments.test
  llvm/utils/UpdateTestChecks/common.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110143.373928.patch
Type: text/x-patch
Size: 7372 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210921/1fcb29c4/attachment.bin>


More information about the llvm-commits mailing list