[PATCH] D110141: Fixed relative address in LNT profile control-flow graph.

Tamar Christina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 07:16:03 PDT 2021


tnfchris added a comment.

In D110141#3012518 <https://reviews.llvm.org/D110141#3012518>, @thopre wrote:

> In D110141#3012486 <https://reviews.llvm.org/D110141#3012486>, @kpdev42 wrote:
>
>> I think it is no need to revert 6ba06570364b936c6bfb631e9d2e4f1374446bad <https://reviews.llvm.org/rLNT6ba06570364b936c6bfb631e9d2e4f1374446bad> - it looks like right solution
>> I've moved my changes to https://reviews.llvm.org/D110174
>
> Argh sorry too late. Should I revert everything then or are we all good?

No it's fine , we're good now. I don't like 6ba06570364b936c6bfb631e9d2e4f1374446bad <https://reviews.llvm.org/rLNT6ba06570364b936c6bfb631e9d2e4f1374446bad> because it assume consistencies between disassemblers which is not the case.


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110141/new/

https://reviews.llvm.org/D110141



More information about the llvm-commits mailing list