[PATCH] D109700: [InstCombine] Improve TryToSinkInstruction with multiple uses

Tue Sep 21 07:02:35 PDT 2021

anna added a comment.

In D109700#3004612 <https://reviews.llvm.org/D109700#3004612>, @nikic wrote:

> Still LGTM, though I'd be interested in knowing what was wrong with the AssumeBundleBuilder case. It's not entirely obvious to me why the switch to getUniqueUndroppableUser() caused issues there.

I will check that separately and address. The lit testcase may just require an update. However, the unit-test which fails building (because of absence of the `use` API: `getSingleUndroppableUse`) 
calls `AbstractCallSite(const Use *U)` constructor. That still requires the `getSingleUndroppableUse` to be around.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109700/new/

https://reviews.llvm.org/D109700