[PATCH] D109217: [llvm-dwarfdump] Fix unsigned overflow when calculating stats

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 05:51:14 PDT 2021


djtodoro added a comment.

In D109217#3011103 <https://reviews.llvm.org/D109217#3011103>, @dblaikie wrote:

> In D109217#3009505 <https://reviews.llvm.org/D109217#3009505>, @djtodoro wrote:
>
>> - addressing comments
>>   - now the warning looks as follows:
>>
>>
>>
>>   "#call site DIEs": N (llvm-dwarfdump: warning: this field overflows),
>
> Maybe we could render it symbolically and just say:
>
>   "#call site DIEs": >= 9223372036854775807
>
> But yeah, maybe the warning is more suitable, not sure - I'll leave it up to you folks to decide what's best.

I'd prefer the warning since it will be easier when parsing the JSON data from utilities such as `llvm-locstats`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109217/new/

https://reviews.llvm.org/D109217



More information about the llvm-commits mailing list