[PATCH] D110143: [Utils] Replace llc with cat for tests

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 03:11:42 PDT 2021


arichardson requested changes to this revision.
arichardson added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/amdgpu-no-merge-comments.test:5
+# RUN: cp -f %S/Inputs/amdgpu_no_merge_comments-O0.s %T/ && cp -f %S/Inputs/amdgpu_no_merge_comments-O3.s %T/
+# RUN: cp -f %S/Inputs/amdgpu_no_merge_comments.ll %t.ll && %update_llc_test_checks --llc-binary cat %t.ll
 # RUN: diff -u %S/Inputs/amdgpu_no_merge_comments.ll.expected %t.ll
----------------
IMO this should be in a separate test file since it's not checking "that functions with different IR comments in the output are not merged" but instead is checking the %S lit substitution


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110143/new/

https://reviews.llvm.org/D110143



More information about the llvm-commits mailing list