[PATCH] D109154: [GlobalISel] Improve elimination of dead instructions in legalizer

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 02:46:14 PDT 2021


Petar.Avramovic added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir:5
 # RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx900 -run-pass=legalizer -global-isel-abort=0 %s -o - | FileCheck -check-prefix=GFX9  %s
-# RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1010 -run-pass=legalizer -global-isel-abort=0 %s -o - | FileCheck -check-prefix=GFX9  %s
 
----------------
foad wrote:
> Did you mean to remove this line? Is codegen different for GFX9 and GFX10 now?
No, missed that. Basically when two lines share check prefix script(update_mir_test_checks) shuffles check blocks, so I run script without shared prefixes and then return # RUN: lines that share prefix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109154/new/

https://reviews.llvm.org/D109154



More information about the llvm-commits mailing list