[PATCH] D110054: [AMDGPU] - change ASAN init/fini kernels linkage to external.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 02:39:58 PDT 2021


foad added a comment.

Nit: first line of commit message should be more like `[AMDGPU] Change ASAN init/fini kernels to use external linkage` (with a capital letter but without a period). And there's no need to repeat this in the body of the commit message. Either leave it blank, or add some text that explains the reason for the change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110054/new/

https://reviews.llvm.org/D110054



More information about the llvm-commits mailing list