[PATCH] D110061: [SelectionDAG] Remove PromoteIntOp_EXTRACT_SUBVECTOR.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

In D110061#3010295 <https://reviews.llvm.org/D110061#3010295>, @craig.topper wrote:

> I'm not sure we can write a test for RISCV either. This can only happen if the element type needs to be promoted on the larger vector type, but not the narrower vector type used for the result. I don't even know to exercise this code with fixed vectors. The llvm-cov bot says its untested http://lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp.html#L5001.  Looks like it was added to support some case with mask vectors on X86, but that case no longer happens. Maybe we can just delete it?

Thanks, I wasn't aware of a code-coverage buildbot that actually showed this info, that's very useful. Is there a more friendly interface to get such a report? (Other than manually constructing the URL with a path to the file)

I've removed the function now and think it makes sense, because I can't think of any instance where the result type would be legal, and the (wider vector) input type requiring promotion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110061/new/

https://reviews.llvm.org/D110061