[PATCH] D102821: [SelectionDAG] Re-calculate scoped AA metadata when merging stores.

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere accepted this revision.
jeroen.dobbelaere added a comment.
This revision is now accepted and ready to land.

LGTM. Just some small nits.



================
Comment at: llvm/test/CodeGen/AArch64/merge-scoped-aa-store.ll:15-16
+
+define void @blam(<3 x float>* %g0, <3 x float>* %g1) {
+; MIR-LABEL: name: blam
+; MIR: STRDui killed %5, %1, 0 :: (store (s64) into %ir.tmp41, align 4, !alias.scope ![[SET1]], !noalias ![[SET0]])
----------------
- Rename this to 'blam0'. That makes it impossible for the MIR-LABEL to match 'blam1'.
- also check for the 'LDRdui  (including the metadata) ? (It's not the explicit goal of the test as such, but imho it makes sense to ensure that the scopes are still matching.)



================
Comment at: llvm/test/CodeGen/AArch64/merge-scoped-aa-store.ll:36
+; MIR: body:
+; MIR: STRDui killed %5, %1, 0 :: (store (s64) into %ir.tmp41, align 4, !alias.scope ![[MMSET0]], !noalias ![[MMSET1]])
+  %tmp4 = getelementptr inbounds <3 x float>, <3 x float>* %g1, i64 0, i64 0
----------------
Also here, I think it makes sense to add a check for LDRdui ? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102821/new/

https://reviews.llvm.org/D102821