[PATCH] D109767: [update_mir_test_checks.py] Use -NEXT FileCheck directories

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

In D109767#3010871 <https://reviews.llvm.org/D109767#3010871>, @aemerson wrote:

> Wait...with this change we now have to regenerate every single MIR test before we make a change if it was using the old behavior. @arsenm what do you think?
>
> I would prefer to have this behavior by opt-in.

Regenerating first will produce smaller diffs, but a sufficiently smart diff viewer (unfortunately not the GitHub one) will highlight only the actual changes (phabricator does an okay job at this). For larger changes I agree that it probably make sense to regenerate first.
I can add an opt-in flag, but IMO we should gradually transition all tests that are updated to the non-fragile -NEXT check lines instead of keeping the fragile CHECK lines that can allow tests to still pass even if certain instructions are no longer optimized out, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109767/new/

https://reviews.llvm.org/D109767