[PATCH] D109534: fixed ambiguous overload build failure

Tue Sep 21 00:26:10 PDT 2021

jhenderson added a comment.

In D109534#3003141 <https://reviews.llvm.org/D109534#3003141>, @juchem wrote:

> @Higuoxing I was under the impression the patch file I've uploaded had that already. How do I add this information through the phabricator UI, since I don't have the command line tools installed?

The "Download Raw Diff" file doesn't contain any details. I don't know of any way to retrieve details via the UI. For some users, it might be possible to get the info from the uploaded patch, if they use the `arcanist` tool. However, many people don't use that tool (such as myself). As such, you'll need to post your details directly in this thread, or email them directly to whoever is going to land the patch for you. Usually the person who lands the patch would be someone involved in the review (e.g. @jmorse/@StephenTozer), or someone you work directly with who has commit access. If nobody else is able to, I can commit if needed.

Unrelated to landing the patch, but in the future, please upload diffs with full context (i.e. add something like -U999999), as this makes it easier to review. Also, as the two fixes are not really related (they're in completely different parts of the code base), typically I'd have done this in two different patches, but I'm not suggesting you split them up now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109534/new/

https://reviews.llvm.org/D109534