[PATCH] D110034: [InstCombine] Update vector transforms to use poison instead of undef for insertelement and shufflevector's placeholder

[Hyeongyu Kim via Phabricator via llvm-commits]

hyeongyukim added a comment.

In D110034#3009544 <https://reviews.llvm.org/D110034#3009544>, @spatel wrote:

> We have a one-vector-input create function in IRBuilder, so it was easy to update that in one place with D93793 <https://reviews.llvm.org/D93793>. Could we do the same for the raw ShuffleVectorInst constructor?

`IRBuilder::CreateShuffleVector(Value *V, ArrayRef<int> Mask, const Twine &Name = "")`  function seems appropriate. I will use this function.

> Do we need to update all of these in one commit to avoid regressions, or can this be split up to reduce risk?

It seems good to reduce the risk.
I will modify the four files below one by one so that they can be easily found if a problem occurs. Thanks!

  InstCombineCasts.cpp
  InstCombineCompares.cpp
  InstCombineVectorOps.cpp
  InstructionCombining.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110034/new/

https://reviews.llvm.org/D110034