[PATCH] D109970: [DebugInfo] Support DW_AT_defaulted

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 18:44:25 PDT 2021


dblaikie added a comment.

In D109970#3010195 <https://reviews.llvm.org/D109970#3010195>, @probinson wrote:

> I've poked around in the copy of gdb that we're using for testing; I see it noting DW_AT_defaulted, and factoring it into pass by reference/value decisions; but, if DW_AT_calling_convention is present, the latter takes precedence.
> It looks like CGDebugInfo::CreateLimitedType will always set the CC flags for a CXXRecordDecl, and I think we always go through that path for complete type descriptions, so I accept that DW_AT_defaulted isn't really necessary.
>
> On those grounds, I'll commit the dumper test (under the test/tools tree, not DebugInfo) but abandon the rest of it.

Sounds good, thanks for checking around & for the extra test coverage!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109970/new/

https://reviews.llvm.org/D109970



More information about the llvm-commits mailing list