[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

Mon Sep 20 18:28:26 PDT 2021

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057
+
+  Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(),
+                                            StackSize));
----------------
jhuber6 wrote:
> tianshilei1992 wrote:
> > Do we want to check somewhere if it's a valid value?
> It's an unsigned value that corresponds to how much memory gets allocated, every value should be equally valid since we don't really know how much memory there is. I was considering making it a 64-bit unsigned as well, but I figured no one would need that much shared memory.
That makes sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110108/new/

https://reviews.llvm.org/D110108