[PATCH] D110081: [llvm-profgen] Filter out invalid debug line

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 17:15:05 PDT 2021


wenlei added a comment.

I think I've seen negative line offsets due to use of macro. If macro is used the line info may point to location where the macro is defined, then it can lead to negative line offset if we use function start line as the base.

In such cases, negative offset should still work for correlating profile back to IR.. What is the corresponding line offset you saw on relevant IR? Do they match the offset in the profile?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110081/new/

https://reviews.llvm.org/D110081



More information about the llvm-commits mailing list