[PATCH] D110049: [AMDGPU] Correctly merge alias.scope and noalias metadata for memops

Mon Sep 20 16:41:59 PDT 2021

arsenm added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/lower-lds-struct-aa-memcpy.ll:20
+; CHECK-LABEL: @test
+; CHECK: store i8 3, i8 addrspace(3)* %0, align 4, !alias.scope !0, !noalias !3
+; CHECK: tail call void @llvm.memcpy.p3i8.p3i8.i64(i8 addrspace(3)* noundef align 1 dereferenceable(3) %2, i8 addrspace(3)* noundef align 1 dereferenceable(3) %1, i64 3, i1 false), !alias.scope !6, !noalias !7
----------------
rampitec wrote:
> It is unclear from the test what are these !0, !3 etc values. Could you include it in the checks?
I think update_test_checks support checking metadata nodes these days

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110049/new/

https://reviews.llvm.org/D110049