[PATCH] D108394: add tsan shared library

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 15:49:57 PDT 2021


vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

I suspect that test part of this patch has higher chances of revert.
I would still recommend to split in two:

1. compiler-rt/cmake/config-ix.cmake and compiler-rt/lib/tsan/CMakeLists.txt
2. the rest



================
Comment at: compiler-rt/test/tsan/CMakeLists.txt:142
+  add_lit_testsuite(check-tsan-dynamic "Running the ThreadSanitizer tests with dynamic runtime"
+                    ${TSAN_DYNAMIC_TESTSUITES}
+                    DEPENDS ${TSAN_DYNAMIC_TEST_DEPS})
----------------
please add EXCLUDE_FROM_CHECK_ALL for dynamic for now and it's fine to land



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108394/new/

https://reviews.llvm.org/D108394



More information about the llvm-commits mailing list