[PATCH] D110107: AMDGPU: Propagate amdgpu-waves-per-eu

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 15:13:00 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:651
+    intersectKnown(Range);
+  }
+
----------------
jdoerfert wrote:
> Is it on purpose that you use the assumed/initial value of the flat-work-group-size as known range here?
Yes, but I wasn't completely sure if this was the correct way to handle this. The amdgpu-flat-workgroup-size implies restrictions on amdgpu-waves-per-eu, but amdgpu-flat-workgroup-size should win if there's a conflict. There should always be an initially known range


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110107/new/

https://reviews.llvm.org/D110107



More information about the llvm-commits mailing list