[PATCH] D109991: [AMDGPU] NFC to correct typos in lib/Target/AMDGPU/AMDGPU*.cpp files. Test commit for new contributor.
Austin Kerbow via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 20 13:23:28 PDT 2021
kerbowa accepted this revision.
kerbowa added a comment.
This revision is now accepted and ready to land.
LGTM with nits.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:62
-/// \returs true if this is an odd sized vector which should widen by adding an
+/// Returns true if this is an odd sized vector which should widen by adding an
/// additional element. This is mostly to handle <3 x s16> -> <4 x s16>. This
----------------
NIT: this is meant to be a doxygen comment I think. So \returns?
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURewriteOutArguments.cpp:145
// some casts between structs and non-structs, but we can't bitcast
- // directly between them. directly bitcast between them. Blender uses
+ // directly between them. Blender uses
// some casts that look like { <3 x float> }* to <4 x float>*
----------------
NIT: This line looks a bit short.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109991/new/
https://reviews.llvm.org/D109991
More information about the llvm-commits
mailing list