[PATCH] D110075: [LTO] [Legacy] Add -debug-pass-manager option to enable pass run/skip trace.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:136
   };
+  Config.DebugPassManager = DebugPassManager;
 }
----------------
Needed in ThinLTOCodeGenerator.cpp too? Looks like it is passed down from llvm-lto to there but I assume you wanted to set this via the linker? Not a legacy LTO user though, @steven_wu may have more thoughts.


================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:172
+namespace llvm {
+  extern cl::opt<bool> DebugPassManager;
+}
----------------
It seems a little odd to have the new LTO tool rely on an option in the legacy LTO. Maybe the def should be moved to LTO.cpp which is the new LTO and which the legacy LTO is gradually starting to use?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110075/new/

https://reviews.llvm.org/D110075