[PATCH] D110061: [SelectionDAG] Fix PromoteIntOp_EXTRACT_SUBVECTOR for scalable vectors.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 12:33:26 PDT 2021


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

I'm not sure we can write a test for RISCV either. This can only happen if the element type needs to be promoted on the larger vector type, but not the narrower vector type used for the result. I don't even know to exercise this code with fixed vectors. The llvm-cov bot says its untested http://lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp.html#L5001.  Looks like it was added to support some case with mask vectors on X86, but that case no longer happens. Maybe we can just delete it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110061/new/

https://reviews.llvm.org/D110061



More information about the llvm-commits mailing list