[PATCH] D109963: [AArch64] Split bitmask immediate of bitwise AND operation

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/aarch64-split-and-bitmask-immediate.ll:8
+; CHECK-NEXT:    and w8, w0, #0x3ffc00
+; CHECK-NEXT:    and w8, w8, #0xffe007ff
+; CHECK-NEXT:    cmp w8, #1024
----------------
Do we want to do something different if the operation is in a loop, so the immediate could be hoisted?


================
Comment at: llvm/test/CodeGen/AArch64/arm64-ccmp.ll:374
+; CHECK-NEXT:    and x8, x8, #0x3f
+; CHECK-NEXT:    and x8, x8, #0xffffffffffffffdf
 ; CHECK-NEXT:    ccmp x8, #0, #4, ls
----------------
This looks wrong?


================
Comment at: llvm/test/CodeGen/AArch64/bitfield-insert.ll:13
+; CHECK-NEXT:    and w8, w0, #0xff
+; CHECK-NEXT:    and w8, w8, #0xffffff87
 ; CHECK-NEXT:    bfi w8, w1, #3, #4
----------------
This isn't an improvement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109963/new/

https://reviews.llvm.org/D109963