[PATCH] D110019: [gn build] improve write_cmake_config to be truthy and exception friendly

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Can you explain the motivation behind this?

> Besides, in order to substiute #cmakedefine var with value,
> it needs to access "values[key]" which will raises a "KeyError"
> exception if searching for a key that does not exist.

That part is intentional, to make sure the list of keys passed to the script matches exactly the list of keys needed in the cmake file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110019/new/

https://reviews.llvm.org/D110019