[PATCH] D109873: Add use_default_shell_env = True to ctx.actions.run

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 10:09:59 PDT 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rGf4b5d597d86a: Add use_default_shell_env = True to ctx.actions.run (authored by Flamefire, committed by GMNGeoffrey).

Changed prior to commit:
  https://reviews.llvm.org/D109873?vs=373495&id=373638#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109873/new/

https://reviews.llvm.org/D109873

Files:
  utils/bazel/llvm-project-overlay/mlir/tblgen.bzl


Index: utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
+++ utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
@@ -169,6 +169,10 @@
         inputs = trans_srcs,
         executable = ctx.executable.tblgen,
         arguments = [args],
+        # Make sure action_env settings are honored so the env is the same as
+        # when the tool was built. Important for locating shared libraries with
+        # a custom LD_LIBRARY_PATH.
+        use_default_shell_env = True,
         mnemonic = "TdGenerate",
     )
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109873.373638.patch
Type: text/x-patch
Size: 634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210920/c5098ff4/attachment.bin>


More information about the llvm-commits mailing list