[PATCH] D105105: [DSE][NFC] Extend isOverwrite to take non zero initial offset

Mon Sep 20 06:39:53 PDT 2021

fhahn added a comment.

In D105105#3008901 <https://reviews.llvm.org/D105105#3008901>, @ebrevnov wrote:

> In D105105#3005752 <https://reviews.llvm.org/D105105#3005752>, @fhahn wrote:
>
>> It's hard to evaluate the impact of the change on its own. Is it strictly required for D90095 <https://reviews.llvm.org/D90095> or could if be a follow-up to D90095 <https://reviews.llvm.org/D90095> where we can show improvements on tests for this patch?
>
> This should be doable. Do you want me to keep this as a separate NFC change or merge with functional change in PHI translation?

If possible, I think it would be best to update D90095 <https://reviews.llvm.org/D90095> to not require this change. I assume this will mean some cases will be missed. Ideally this patch would then be a follow-up to D90095 <https://reviews.llvm.org/D90095> where it is not NFC but has a functional impact and the impact is obvious from the test changes. Would that work?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105105/new/

https://reviews.llvm.org/D105105