[PATCH] D105020: [SLP]Improve graph reordering.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 05:59:09 PDT 2021


ABataev added a comment.

In D105020#3009208 <https://reviews.llvm.org/D105020#3009208>, @RKSimon wrote:

> In D105020#3009190 <https://reviews.llvm.org/D105020#3009190>, @ABataev wrote:
>
>> Thanks again for the reproducer, checked it with the last version uploaded on Friday, the results are correct. I fixed the incorrect reordering of the nodes with the alternate instructions.
>
> LGTM - if you can add another (useful) test case for the latest repro that'd be great.

Actually, already added. I used the previous reproducer, added `test/Transforms/SLPVectorizer/X86/vectorize-reorder-alt-shuffle.ll` which revealed the bug in the previous version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105020/new/

https://reviews.llvm.org/D105020



More information about the llvm-commits mailing list