[PATCH] D110058: [SelectionDAG] Make WidenVecRes_Convert work for scalable vectors.

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 05:32:48 PDT 2021


david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/test/CodeGen/AArch64/sve-fcvt.ll:740
+; CHECK-NEXT:    mov z0.s, p0/z, #1 // =0x1
+; CHECK-NEXT:    ptrue p0.s
+; CHECK-NEXT:    ucvtf z0.h, p0/m, z0.s
----------------
david-arm wrote:
> Hi @sdesmalen, not sure this is caused by your patch, but this looks a bit odd as we're defining p0.s after it's already been used above.
My mistake - we're using the input p0 passed to the function. Doh!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110058/new/

https://reviews.llvm.org/D110058



More information about the llvm-commits mailing list