[PATCH] D109513: [AsmPrinter, SystemZ] Allow target to add instructions before section is ended.

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

Two minor nits inline, otherwise I agree we should go with that approach now.



================
Comment at: llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCTargetDesc.cpp:15
 #include "llvm/MC/MCDwarf.h"
+#include "llvm/MC/MCContext.h"
 #include "llvm/MC/MCInstrInfo.h"
----------------
Agree with the linter here, please keep the includes sorted alphabetically.


================
Comment at: llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp:553
+    SystemZTargetStreamer *TS = getTargetStreamer();
+    assert(TS && "do not have a target streamer");
     MCSymbol *DotSym = nullptr;
----------------
Maybe move the assert into the getTargetStreamer() routine, just like in the AsmParser?   (In fact, do we really need two copies of the getTargetStreamer() routine now?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109513/new/

https://reviews.llvm.org/D109513